[
https://issues.apache.org/jira/browse/ARTEMIS-5069?focusedWorklogId=1010154&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1010154
]
ASF GitHub Bot logged work on ARTEMIS-5069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/26 19:29
Start Date: 18/Mar/26 19:29
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #6301:
URL: https://github.com/apache/artemis/pull/6301#discussion_r2955727848
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AddressInfo.java:
##########
@@ -439,4 +439,17 @@ public static AddressInfo fromJSON(String jsonString) {
public long getCreatedTimestamp() {
return createdTimestamp;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (o == null || getClass() != o.getClass())
Review Comment:
Should be using brackets per our style policy
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RoutingContextImpl.java:
##########
@@ -211,11 +212,11 @@ public void addQueue(final SimpleString address, final
Queue queue) {
listing.getNonDurableQueues().add(queue);
}
- if (internalOnly == null) {
- internalOnly = queue.isInternalQueue();
+ if (mirrorIgnore == null) {
+ mirrorIgnore = queue.isInternalQueue() || queue.isTemporary();
} else {
// every queue added has to be internal only
Review Comment:
Comment doesn't match the logic now
Issue Time Tracking
-------------------
Worklog Id: (was: 1010154)
Time Spent: 0.5h (was: 20m)
> Sends are still hitting the mirror target on temporary queues
> -------------------------------------------------------------
>
> Key: ARTEMIS-5069
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5069
> Project: Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> on ARTEMIS-5068 I fixed the create queues for temporary queues should not hit
> the target server. However the sends of the messages will still be sent
> through the MirrorSNF, hit the server and not find anything.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
