[
https://issues.apache.org/jira/browse/ARTEMIS-5069?focusedWorklogId=1010406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1010406
]
ASF GitHub Bot logged work on ARTEMIS-5069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/26 17:05
Start Date: 19/Mar/26 17:05
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #6301:
URL: https://github.com/apache/artemis/pull/6301#discussion_r2961416761
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/BrokerInSyncTest.java:
##########
@@ -265,18 +266,89 @@ public void testSingleMessage(String protocol) throws
Exception {
session1.commit();
}
- try {
- connection1.close();
- } catch (Exception ignored) {
+ connection1.close();
+ connection2.close();
+
+ Wait.assertEquals(0L, queueOnServer1::getMessageCount, 5000, 100);
+ Wait.assertEquals(0L, queueOnServer2::getMessageCount, 5000, 100);
+
+ server_2.stop();
+ server.stop();
+ }
+
+ @Test
+ public void testNoTemporaryQueues() throws Exception {
Review Comment:
The test is named `testNoTemporaryQueues` but its creating temporary topics.
It would be nice to create a set of tests that exercise both to ensure the two
domains are covered in testing for the mirror. Should be simple enough the
create on method that does one type of the other and call it with an option.
Issue Time Tracking
-------------------
Worklog Id: (was: 1010406)
Time Spent: 1h 10m (was: 1h)
> Sends are still hitting the mirror target on temporary queues
> -------------------------------------------------------------
>
> Key: ARTEMIS-5069
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5069
> Project: Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> on ARTEMIS-5068 I fixed the create queues for temporary queues should not hit
> the target server. However the sends of the messages will still be sent
> through the MirrorSNF, hit the server and not find anything.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
