tabish121 commented on code in PR #6324: URL: https://github.com/apache/artemis/pull/6324#discussion_r3024191749
########## artemis-cli/src/main/resources/META-INF/services/org.apache.activemq.artemis.cli.factory.BrokerFactoryHandler: ########## @@ -0,0 +1 @@ +org.apache.activemq.artemis.cli.factory.xml.XmlBrokerFactoryHandler Review Comment: It seems like these service definitions can still have Apache license headers added as the ServiceLoader javadocs indicates it will ignore anything following the '#' character -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
