jbertram commented on code in PR #6324:
URL: https://github.com/apache/artemis/pull/6324#discussion_r3033380934


##########
artemis-cli/src/main/resources/META-INF/services/org.apache.activemq.artemis.cli.factory.BrokerFactoryHandler:
##########
@@ -0,0 +1 @@
+org.apache.activemq.artemis.cli.factory.xml.XmlBrokerFactoryHandler

Review Comment:
   I have no problem adding the license header, but it's worth noting that 
we've specifically configured `apache-rat-plugin` in the root `pom.xml` to 
exclude `**/META-INF/services/*` which means we have a lot of other service 
files without headers (and have for years). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to