clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3024772981
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java:
##########
@@ -119,6 +118,12 @@
*/
public abstract class AMQPMessage extends RefCountMessage implements
org.apache.activemq.artemis.api.core.Message {
+ // The basic (minimal) size an AMQP message uses.
+ // This is an estimate, and it's based on the following test:
+ // By running AMQPGlobalMaxTest::testSendUntilOME, you look at the initial
memory used by the broker without any messages.
+ // By the time you get the OME, you can do some bare calculations on how
much each message uses and get an AVG.
+ public static final int AMQP_OFFSET = 1300;
Review Comment:
I used offset as it was a term used back then... as we "Imagined" allocation
tables/ offsets.. whatever fancy terms we used many years ago. (from
core/offset.. same thing)
MINIMUM_SIZE_ESTIMATE is a much better term.. I agree..
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
