clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3028066244
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPStandardMessage.java:
##########
@@ -237,79 +240,10 @@ public void reloadPersistence(ActiveMQBuffer record,
CoreMessageObjectPools pool
// Message state is now that the underlying buffer is loaded, but the
contents not yet scanned
resetMessageData();
- recoverHeaderDataFromEncoding();
+ scanMessageData(data);
modified = false;
- messageDataScanned = MessageDataScanningStatus.RELOAD_PERSISTENCE.code;
Review Comment:
There was a case where the broker had a lot of data.. but it had a lot of
data because the estimate was under estimated in the first place..
And I don't think we are actually decoding messages.. just parsing the
locations of the application properties.
also I think at some point we were actually decoding application properties
during reload.
It would be great to not have to do this on reload, but the estimates
wouldn't match after reload what could affect further producing messages.
I would rather do it this new way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
