[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1012810&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1012810
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/26 21:33
Start Date: 01/Apr/26 21:33
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3024772981
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java:
##########
@@ -119,6 +118,12 @@
*/
public abstract class AMQPMessage extends RefCountMessage implements
org.apache.activemq.artemis.api.core.Message {
+ // The basic (minimal) size an AMQP message uses.
+ // This is an estimate, and it's based on the following test:
+ // By running AMQPGlobalMaxTest::testSendUntilOME, you look at the initial
memory used by the broker without any messages.
+ // By the time you get the OME, you can do some bare calculations on how
much each message uses and get an AVG.
+ public static final int AMQP_OFFSET = 1300;
Review Comment:
I used offset as it was a term used back then... as we "Imagined" allocation
tables/ offsets.. whatever fancy terms we used many years ago. (from
core/offset.. same thing)
MINIMUM_SIZE_ESTIMATE is a much better term.. I agree..
thanks
Issue Time Tracking
-------------------
Worklog Id: (was: 1012810)
Time Spent: 20m (was: 10m)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
