[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1013409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1013409
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/26 20:53
Start Date: 05/Apr/26 20:53
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3037342905
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessage.java:
##########
@@ -604,8 +618,10 @@ public long getWholeMessageSize() {
@Override
public synchronized int getMemoryEstimate() {
if (memoryEstimate == -1) {
- memoryEstimate = memoryOffset * 2 + (extraProperties != null ?
extraProperties.getEncodeSize() : 0);
- originalEstimate = memoryEstimate;
+ // the applicationPropertiesSize is * 4 to give us some room to
estimate the size of the applicationProperties after decoding.
+ // A lot of testing was done in AMQPGlobalMaxTest to determine this
factor. It can always be further adjusted
+ // Also it's better to overestimate than to underestimate as that
could lead to OutOfMemoryException
+ memoryEstimate = MINIMUM_ESTIMATE + (extraProperties != null ?
extraProperties.getEncodeSize() : 0) + applicationPropertiesSize * 4;
Review Comment:
I'm using the count like the core now, but it's not making much difference.
from my tests a more accurate estimate would be 3X.. however I'm using the
number of properties now.
Issue Time Tracking
-------------------
Worklog Id: (was: 1013409)
Time Spent: 1.5h (was: 1h 20m)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
