[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1013883&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1013883
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/26 01:01
Start Date: 08/Apr/26 01:01
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #6323:
URL: https://github.com/apache/artemis/pull/6323#issuecomment-4203133300
The reason I had to add a V4 is because of Paging:
On this part here, I encode the number of queues and the queueIDs:
https://github.com/apache/artemis/blob/5b122779947d402cfebc2997c4c8c1ea08c4d161/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagedMessageImpl.java#L227-L234
At the point of the encoder I don't have any reference to the number of
bytes used by its own decoder.
I'm adding one on V4 now, if in the future anything else is added, we will
stop reading at that marker.
Issue Time Tracking
-------------------
Worklog Id: (was: 1013883)
Time Spent: 4h 40m (was: 4.5h)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
