[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1014313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1014313
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/26 15:56
Start Date: 09/Apr/26 15:56
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3059088430
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java:
##########
@@ -155,7 +155,7 @@ public abstract class AMQPMessage extends RefCountMessage
implements org.apache.
* developing purposes.
*/
public enum MessageDataScanningStatus {
- NOT_SCANNED(0), SCANNED(1);
+ NOT_SCANNED(0), RELOAD_PERSISTENCE(1), SCANNED(2);
Review Comment:
@tabish121 I pushed a commit that completely eliminates the scanning during
reload.
I could remove the RELOAD status (still thinking about it.. it's only needed
for isPersistent now. I could persist it on the persister as well and just have
it NOT SCANNED.
Please check it out..
(these commits will need to be squashed)
One thing I will work on this afternoon is to add a checker for
LargeMessages as well on AMQPReloadFromPersistenceTest
Issue Time Tracking
-------------------
Worklog Id: (was: 1014313)
Time Spent: 9h (was: 8h 50m)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
