[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1015502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1015502
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/26 15:28
Start Date: 14/Apr/26 15:28
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3080088689
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessagePersisterV2.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.protocol.amqp.broker;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.Message;
+import org.apache.activemq.artemis.core.persistence.CoreMessageObjectPools;
+import org.apache.activemq.artemis.utils.DataConstants;
+
+import static
org.apache.activemq.artemis.core.persistence.PersisterIDs.AMQPLargeMessagePersisterV2_ID;
+
+public class AMQPLargeMessagePersisterV2 extends AMQPLargeMessagePersister {
+
+ public static final byte ID = AMQPLargeMessagePersisterV2_ID;
+
+ public static AMQPLargeMessagePersisterV2 theInstance;
+
+ public static AMQPLargeMessagePersisterV2 getInstance() {
+ if (theInstance == null) {
+ theInstance = new AMQPLargeMessagePersisterV2();
+ }
+ return theInstance;
+ }
+
+ @Override
+ public byte getID() {
+ return ID;
+ }
+
+ public AMQPLargeMessagePersisterV2() {
+ super();
+ }
+
+
+ protected static final int PERSISTER_SIZE = DataConstants.SIZE_INT + //
memory estimate
+ DataConstants.SIZE_BYTE + //
message priority
+ DataConstants.SIZE_BOOLEAN; //
durable
+
+ @Override
+ public int getEncodeSize(Message record) {
+ return super.getEncodeSize(record) +
+ DataConstants.SIZE_INT + // size delimiter for future use to keep
compatibility better
+ PERSISTER_SIZE;
+ }
+
+ @Override
+ public void encode(ActiveMQBuffer buffer, Message record) {
+ super.encode(buffer, record);
+
+ AMQPLargeMessage msgEncode = (AMQPLargeMessage) record;
+ writeSizeDelimiter(buffer);
+ buffer.writeInt(msgEncode.getMemoryEstimate());
+ buffer.writeByte(msgEncode.getPriority());
+ buffer.writeBoolean(msgEncode.isDurable());
Review Comment:
This is written already by the previous persister (plus its already
implicitly in the message itself), is it really necessary to write it yet again?
Issue Time Tracking
-------------------
Worklog Id: (was: 1015502)
Time Spent: 10.5h (was: 10h 20m)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
