[
https://issues.apache.org/jira/browse/ARTEMIS-6037?focusedWorklogId=1018299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1018299
]
ASF GitHub Bot logged work on ARTEMIS-6037:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/26 18:49
Start Date: 01/May/26 18:49
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6396:
URL: https://github.com/apache/artemis/pull/6396#discussion_r3174672722
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java:
##########
@@ -407,11 +407,19 @@ public void handlePacket(Packet packet) {
ClusterConnectMessage msg = (ClusterConnectMessage) packet;
- if (server.getConfiguration().isSecurityEnabled() &&
!clusterConnection.verify(msg.getClusterUser(), msg.getClusterPassword())) {
- clusterChannel.send(new ClusterConnectReplyMessage(false));
- } else {
+ boolean userIsValid = false;
+ try {
+ server.validateUser(msg.getClusterUser(),
msg.getClusterPassword(), null, null);
+ userIsValid = true;
+ } catch (Exception e) {
+ // cluster user isn't valid
Review Comment:
@jbertram I was recently in a customer case and the code was "eating" an
exception like this.
Even though this is logged elsewhere, I would appreciate if we had at least
log.debug(e.getMessage(), e) (or trace if you prefer).
I would avoid any sort of "eating" an exception, without log.debug or trace
Issue Time Tracking
-------------------
Worklog Id: (was: 1018299)
Time Spent: 1h 40m (was: 1.5h)
> Refactor handling of cluster credentials
> ----------------------------------------
>
> Key: ARTEMIS-6037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-6037
> Project: Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> To strengthen broker security out-of-the-box we should reject any connection
> using the default cluster credentials. We already force users to explicitly
> select a custom username and password when a non-clustered broker instance is
> created. Additionally, we force them to explicitly select custom cluster
> credentials when creating a clustered broker instance. However, there are
> still default values for cluster credentials that we should categorically
> reject.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
