[ 
https://issues.apache.org/jira/browse/ARTEMIS-6037?focusedWorklogId=1019839&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1019839
 ]

ASF GitHub Bot logged work on ARTEMIS-6037:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/May/26 13:36
            Start Date: 12/May/26 13:36
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #6436:
URL: https://github.com/apache/artemis/pull/6436#discussion_r3226811709


##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -451,7 +451,7 @@ protected void setClusterPassword(String clusterPassword) {
 
    protected String getClusterPassword() {
       if (clusterPassword == null) {
-         clusterPassword = inputPassword("--cluster-password", "What is the 
cluster password?", "password-admin");
+         clusterPassword = inputPassword("--cluster-password", "What is the 
cluster password?", ActiveMQDefaultConfiguration.getDefaultClusterPassword());

Review Comment:
   I actually already implemented that on my branch for ARTEMIS-6055. I'll 
close this PR and handle this as part of the general case for all passwords.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 1019839)
    Time Spent: 3h  (was: 2h 50m)

> Refactor handling of cluster credentials
> ----------------------------------------
>
>                 Key: ARTEMIS-6037
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-6037
>             Project: Artemis
>          Issue Type: Task
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> To strengthen broker security out-of-the-box we should reject any connection 
> using the default cluster credentials. We already force users to explicitly 
> select a custom username and password when a non-clustered broker instance is 
> created. Additionally, we force them to explicitly select custom cluster 
> credentials when creating a clustered broker instance. However, there are 
> still default values for cluster credentials that we should categorically 
> reject.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to