RyanSkraba commented on a change in pull request #883:
URL: https://github.com/apache/avro/pull/883#discussion_r427386011
##########
File path:
lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java
##########
@@ -328,6 +328,11 @@ private void getClassNamesOfPrimitiveFields(Schema schema,
Set<String> result, S
break;
case ENUM:
case FIXED:
Review comment:
The `ENUM` case will fall through here! This probably won't be an
issue, but it would probably be more clear to give it its own `break;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
