RyanSkraba commented on a change in pull request #883:
URL: https://github.com/apache/avro/pull/883#discussion_r429190305
##########
File path:
lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java
##########
@@ -328,6 +328,11 @@ private void getClassNamesOfPrimitiveFields(Schema schema,
Set<String> result, S
break;
case ENUM:
case FIXED:
Review comment:
If that's the case, do you think it would be possible to unifying the
logic with `result.add(javaType(scheme, true))` for all non-complex types? I'm
not sure what the real answer is, I'm interested in your opinion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
