blachniet commented on a change in pull request #981: URL: https://github.com/apache/avro/pull/981#discussion_r526533237
########## File path: lang/csharp/versions.props ########## @@ -0,0 +1,63 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + https://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<!-- + See lang/csharp/README.md for tool and library dependency update strategy +--> + +<Project> + <!-- + These package versions are the latest, which are tools are packaged with. Review comment: ```suggestion These package versions are the latest, which our tools are packaged with. ``` ########## File path: lang/csharp/README.md ########## @@ -12,9 +12,16 @@ Install-Package Apache.Avro ## Build & Test -1. Install [.NET Core SDK 2.2+](https://www.microsoft.com/net/download/linux) +1. Install [.NET SDK 5.0+](https://dotnet.microsoft.com/download/dotnet-core) 2. `dotnet test` +## Dependency package version strategy + +1. Use [versions.props](./versions.props) to specify package versions. PackageReference in csproj files should use only version properties defined in [versions.props](./versions.props) Review comment: Just some formatting preferences suggestions 😄 ```suggestion 1. Use [`versions.props`](./versions.props) to specify package versions. `PackageReference` elements in `.csproj` files should use only version properties defined in [`versions.props`](./versions.props). ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
