blachniet commented on a change in pull request #981: URL: https://github.com/apache/avro/pull/981#discussion_r528047610
########## File path: lang/csharp/README.md ########## @@ -12,9 +12,16 @@ Install-Package Apache.Avro ## Build & Test -1. Install [.NET Core SDK 2.2+](https://www.microsoft.com/net/download/linux) +1. Install [.NET SDK 5.0+](https://dotnet.microsoft.com/download/dotnet-core) 2. `dotnet test` +## Dependency package version strategy + +1. Use [`versions.props`](./versions.props) to specify package versions. `PackageReference` elements in `.csproj` files should use only version properties defined in [`versions.props`](./versions.props). + +2. By updating the versions in our libraries, we require users of the library to update to a version equal to or greater than the version we reference. For example, if a user were to reference an older version of Newtonsoft.Json, the would be forced to update to a newer version before they could use a new version of the Avro library. Review comment: Whoops, sorry, this is my typo, and I missed it the last go round. ```suggestion 2. By updating the versions in our libraries, we require users of the library to update to a version equal to or greater than the version we reference. For example, if a user were to reference an older version of Newtonsoft.Json, they would be forced to update to a newer version before they could use a new version of the Avro library. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
