martin-g commented on a change in pull request #1358:
URL: https://github.com/apache/avro/pull/1358#discussion_r795426443
##########
File path: lang/csharp/src/apache/main/File/Codec.cs
##########
@@ -43,9 +44,10 @@ public abstract class Codec
/// <summary>
/// Decompress data using implemented codec
/// </summary>
- /// <param name="compressedData"></param>
+ /// <param name="compressedData">The buffer holding data to
decompress.</param>
+ /// <param name="length">The actual length of bytes to decompress from
the buffer.</param>
/// <returns></returns>
- abstract public byte[] Decompress(byte[] compressedData);
+ abstract public byte[] Decompress(byte[] compressedData, int length);
Review comment:
Since you force pushed it is hard to see how you improved it.
Now we have two similar methods in the API and at least to me it is not very
clear when to use each one.
I'll let someone else who has experience with C# to decide whether this PR
should be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
