martin-g commented on a change in pull request #1358:
URL: https://github.com/apache/avro/pull/1358#discussion_r795450525
##########
File path: lang/csharp/src/apache/main/File/Codec.cs
##########
@@ -43,9 +44,10 @@ public abstract class Codec
/// <summary>
/// Decompress data using implemented codec
/// </summary>
- /// <param name="compressedData"></param>
+ /// <param name="compressedData">The buffer holding data to
decompress.</param>
+ /// <param name="length">The actual length of bytes to decompress from
the buffer.</param>
/// <returns></returns>
- abstract public byte[] Decompress(byte[] compressedData);
+ abstract public byte[] Decompress(byte[] compressedData, int length);
Review comment:
The best is to use new commits after a review. Otherwise we have to
re-review the whole thing again and again.
Once the PR is approved we use GitHub's "Squash & Merge" button. This way
all the commit messages are preserved for the final commit. So, better use good
commit messages! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
