tgnm commented on a change in pull request #1358:
URL: https://github.com/apache/avro/pull/1358#discussion_r795430079
##########
File path: lang/csharp/src/apache/main/File/Codec.cs
##########
@@ -43,9 +44,10 @@ public abstract class Codec
/// <summary>
/// Decompress data using implemented codec
/// </summary>
- /// <param name="compressedData"></param>
+ /// <param name="compressedData">The buffer holding data to
decompress.</param>
+ /// <param name="length">The actual length of bytes to decompress from
the buffer.</param>
/// <returns></returns>
- abstract public byte[] Decompress(byte[] compressedData);
+ abstract public byte[] Decompress(byte[] compressedData, int length);
Review comment:
I thought I had read somewhere in the contribution guidelines that a
single commit per issue was preferred. However, I've read the guidelines again
and I cannot find it. Is the preference to have multiple commits and squash
merge at the end?
The change I've pushed is simply to overload the method so that you have
both method signatures, the one without a length argument and the one with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
