tgnm commented on a change in pull request #1358:
URL: https://github.com/apache/avro/pull/1358#discussion_r795529985
##########
File path: lang/csharp/src/apache/main/File/Codec.cs
##########
@@ -43,9 +44,10 @@ public abstract class Codec
/// <summary>
/// Decompress data using implemented codec
/// </summary>
- /// <param name="compressedData"></param>
+ /// <param name="compressedData">The buffer holding data to
decompress.</param>
+ /// <param name="length">The actual length of bytes to decompress from
the buffer.</param>
/// <returns></returns>
- abstract public byte[] Decompress(byte[] compressedData);
+ abstract public byte[] Decompress(byte[] compressedData, int length);
Review comment:
Right, I assumed you were concerned about library consumers who could
potentially still be using `Codec` as it's marked `public` so I avoided making
changes that could break it in any way (including marking as obsolete as that
can break builds if they treat warnings as errors).
I have pushed the changes now so that the old method is `Obsolete`. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
