jklamer commented on pull request #1582:
URL: https://github.com/apache/avro/pull/1582#issuecomment-1060137762


   Just added some tests for union. There is still a bug when the named schema 
is defined inside of the union and is not the union variant that is present in 
the value. The unit tests here will still fail. Im thinking it might make sense 
to make, a wrapped schema type that has the schema and a map of all the named 
schemas within the full structure prepared out. Otherwise all Schema Variants 
will have scanned to get the schema definition information for outer fields. 
   
   Something like:
   ```
   struct ResolvedSchema {
       inner: Schema,
       resolved: HashMap<Name, Schema>
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to