jklamer commented on pull request #1582: URL: https://github.com/apache/avro/pull/1582#issuecomment-1061305123
@martin-g Added the tests as I believe they are intended. On the encoding side I believe the Values must be Union Values in line with the write schema in this case. When I first made these tests incorrectly I came across something I believe we will still need to address. Namely the case where a NamedSchema defined within the Union Variant Record Schema would not get indexed in the map. The solution to this I believe is the same as the proposed flow change both I and @travisbrown had proposed, and I would like to push forward with that ASAP as the fix. These changes stand alone in improving but are incomplete against the spec. @travisbrown any thoughts on what I proposed [here](https://github.com/apache/avro/pull/1582#issuecomment-1060137762). Especially naming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
