zcsizmadia commented on a change in pull request #1565:
URL: https://github.com/apache/avro/pull/1565#discussion_r823071060
##########
File path: lang/csharp/src/apache/test/Avro.test.csproj
##########
@@ -32,13 +32,22 @@
</PropertyGroup>
<ItemGroup>
+ <PackageReference Include="coverlet.collector"
Version="$(CoverletCollectorVersion)">
+ <PrivateAssets>all</PrivateAssets>
+ <IncludeAssets>runtime; build; native; contentfiles; analyzers;
buildtransitive</IncludeAssets>
+ </PackageReference>
+ <PackageReference Include="coverlet.msbuild"
Version="$(CoverletMSBuildVersion)">
+ <PrivateAssets>all</PrivateAssets>
+ <IncludeAssets>runtime; build; native; contentfiles; analyzers;
buildtransitive</IncludeAssets>
+ </PackageReference>
<PackageReference Include="NUnit" Version="$(NUnitVersion)" />
<PackageReference Include="NUnit3TestAdapter"
Version="$(NUnit3TestAdapterVersion)" />
<PackageReference Include="NUnit.ConsoleRunner"
Version="$(NUnitConsoleRunnerVersion)" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk"
Version="$(MicrosoftNETTestSdkVersion)" />
+ <PackageReference Include="ReportGenerator"
Version="$(ReportGeneratorVersion)" />
Review comment:
I think it shows one way which is very usable for cross platforms. The
way it is currently implemented, by calling the report generator from the user
nuget packages folder will be very challenging form a UX point of view:
1. The path will have the version in it, which has to be maintained.
2. Linux vs Windows will be a potential UX issue as well
I understand that we have different views on this, however I think the
report generator should be used via global tool and only the codecoverage
packages should be in the csproj file. It is a small change compared to what
you have as of now. But will make a huge difference from supporting it on the
long term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
