[GitHub] [avro] zcsizmadia commented on a change in pull request #1565: AVRO-3415: Add code coverage report support for csharp

Wed, 09 Mar 2022 12:45:03 -0800 


zcsizmadia commented on a change in pull request #1565:
URL: https://github.com/apache/avro/pull/1565#discussion_r823073469



##########
File path: lang/csharp/src/apache/test/Avro.test.csproj
##########
@@ -32,13 +32,22 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="coverlet.collector" 
Version="$(CoverletCollectorVersion)">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; 
buildtransitive</IncludeAssets>
+    </PackageReference>
+    <PackageReference Include="coverlet.msbuild" 
Version="$(CoverletMSBuildVersion)">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; 
buildtransitive</IncludeAssets>
+    </PackageReference>
     <PackageReference Include="NUnit" Version="$(NUnitVersion)" />
     <PackageReference Include="NUnit3TestAdapter" 
Version="$(NUnit3TestAdapterVersion)" />
     <PackageReference Include="NUnit.ConsoleRunner" 
Version="$(NUnitConsoleRunnerVersion)" />
   </ItemGroup>
 
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" 
Version="$(MicrosoftNETTestSdkVersion)" />
+    <PackageReference Include="ReportGenerator" 
Version="$(ReportGeneratorVersion)" />

Review comment:
       Here is some screenshots I referred to as a "best practive:"" from that 
link:
   
   
![image](https://user-images.githubusercontent.com/8504099/157532339-89af80b6-7f5f-4c6c-a42c-a99eb12e8f0d.png)
   
![image](https://user-images.githubusercontent.com/8504099/157532391-30642d87-545e-41a6-a449-abc40df99a55.png)
   
![image](https://user-images.githubusercontent.com/8504099/157532635-b9d6311e-929e-4566-8ee2-10a7e2d7819a.png)
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to