yanivru commented on a change in pull request #1597:
URL: https://github.com/apache/avro/pull/1597#discussion_r828398569
##########
File path: lang/csharp/src/apache/main/Schema/EnumSchema.cs
##########
@@ -47,6 +48,33 @@ public class EnumSchema : NamedSchema
/// </summary>
public int Count { get { return Symbols.Count; } }
+ /// <summary>
+ /// Initializes a new instance of the <see cref="EnumSchema"/> class.
+ /// </summary>
+ /// <param name="name">name of enum.</param>
+ /// <param name="space">namespace of enum.</param>
+ /// <param name="aliases">list of aliases for the name.</param>
+ /// <param name="symbols">list of enum symbols.</param>
+ /// <param name="customProperties">custom properties on this
schema.</param>
+ /// <param name="doc">documentation for this named schema.</param>
+ /// <param name="defaultSymbol"></param>
+ public EnumSchema(string name,
Review comment:
NewInstance is internal, and it's more of a deserializer than an object
creator, it contains a lot of logic. I can change the public constructors to a
factory method (how should I call it?), is that the 'interface' we want the
schema classes to expose? I think constructor is a bit more convenient to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
