yanivru commented on a change in pull request #1597:
URL: https://github.com/apache/avro/pull/1597#discussion_r838963128
##########
File path: lang/csharp/src/apache/main/Schema/RecordSchema.cs
##########
@@ -162,13 +281,30 @@ private static Field createField(JToken jfield, int pos,
SchemaNames names, stri
return new Field(schema, name, aliases, pos, doc, defaultValue,
sortorder, props);
}
- private static void addToFieldMap(Dictionary<string, Field> map,
string name, Field field)
+ private static void addParsedFieldToFieldMap(Dictionary<string, Field>
map, string name, Field field)
{
if (map.ContainsKey(name))
throw new SchemaParseException("field or alias " + name + " is
a duplicate name");
map.Add(name, field);
}
+ private static void addToFieldMap(Dictionary<string, Field> map,
string name, Field field)
Review comment:
Yes, tried to keep it backward compatible. And it's actually just the
inner exception (I can RecordSchema.NewInstance to throw SchemaParseException
anyway). Is that OK to break compatibility of inner exception?
What do you mean by "call it out"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
