RyanSkraba commented on code in PR #1863:
URL: https://github.com/apache/avro/pull/1863#discussion_r969945995
##########
lang/java/archetypes/avro-service-archetype/src/main/pom/pom.xml:
##########
@@ -79,9 +79,9 @@
<version>\${logback.version}</version>
</dependency>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>\${junit.version}</version>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <version>\${junit5.version}</version>
Review Comment:
Huh -- as far as I remember @opwvhk is correct, and yet JUnit5 tests [are
being
run](https://github.com/apache/avro/actions/runs/3044499132/jobs/4904953694#step:7:404)!
(TestDataFile is definitely a JUnit5 migrated class).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
