RyanSkraba commented on code in PR #1863:
URL: https://github.com/apache/avro/pull/1863#discussion_r969952345
##########
lang/java/archetypes/avro-service-archetype/src/main/pom/pom.xml:
##########
@@ -79,9 +79,9 @@
<version>\${logback.version}</version>
</dependency>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>\${junit.version}</version>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <version>\${junit5.version}</version>
Review Comment:
Oh, my mistake, I see -- yes, this archetype can probably be safely left as
it is (on JUnit4) or entirely migrate the generated test to
[JUnit5](https://github.com/apache/avro/blob/70260919426f89825ca148f5ee815f3b2cf4764d/lang/java/archetypes/avro-service-archetype/src/main/resources/archetype-resources/src/test/java/integration/SimpleOrderServiceIntegrationTest.java#L33-L35)
Lets not mix JUnit4 and JUnit5 in the archetype, however!
##########
lang/java/maven-plugin/pom.xml:
##########
@@ -24,7 +24,7 @@
<artifactId>avro-parent</artifactId>
<groupId>org.apache.avro</groupId>
<version>1.12.0-SNAPSHOT</version>
- <relativePath>../</relativePath>
Review Comment:
Just for info, is this a best practice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
