zcsizmadia commented on code in PR #1956:
URL: https://github.com/apache/avro/pull/1956#discussion_r1020797793
##########
lang/csharp/src/apache/benchmark/Avro.benchmark.csproj:
##########
@@ -31,6 +31,12 @@
<IsPackable>false</IsPackable>
</PropertyGroup>
+ <PropertyGroup>
+ <!-- Some schemas use lower cased names, which causes some class names
being lower case only -->
+ <!-- e.g. The type name 'test' only contains lower-cased ascii characters.
Such names may become reserved for the language. -->
+ <NoWarn>$(NoWarn);CS8981</NoWarn>
+ </PropertyGroup>
Review Comment:
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/warning-waves
btw I think using `@identifier` is not related to this, since that is
regarding for existing keyword conflicts. This new warning is simply about not
using lower case names for types to avoid any potential future C# keyword
conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
