zcsizmadia commented on code in PR #1956:
URL: https://github.com/apache/avro/pull/1956#discussion_r1020906685
##########
lang/csharp/src/apache/benchmark/Avro.benchmark.csproj:
##########
@@ -31,6 +31,12 @@
<IsPackable>false</IsPackable>
</PropertyGroup>
+ <PropertyGroup>
+ <!-- Some schemas use lower cased names, which causes some class names
being lower case only -->
+ <!-- e.g. The type name 'test' only contains lower-cased ascii characters.
Such names may become reserved for the language. -->
+ <NoWarn>$(NoWarn);CS8981</NoWarn>
+ </PropertyGroup>
Review Comment:
Currently there is unit test in the library which makes sure that the
reserved keyword list is up to date with the Roslyn compiler's keyword list.
This means that if a new keyword is added, a unit test will fail which
indicates that the keyword list must be updated. Once tthat keyword list is
updated, avrogen will add @ to a type name if it is a newly introduced keyword.
https://github.com/apache/avro/blob/master/lang/csharp/src/apache/test/CodGen/CodeGenTest.cs#L37-L55
#1595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
