aromanenko-dev commented on code in PR #2137:
URL: https://github.com/apache/avro/pull/2137#discussion_r1132636702
##########
lang/java/avro/src/test/java/org/apache/avro/generic/TestGenericData.java:
##########
@@ -198,6 +198,25 @@ public void testMapValuesEquals() {
assertEquals(r1, r0);
}
+ @Test
+ public void testArrayValuesEqualsStringAndUtf8Compatibility() {
+ Schema arrayElementSchema = new Schema.Parser().parse("{\"type\":
\"string\"}");
Review Comment:
```
Field myMapField = new Field("my_map",
Schema.createMap(Schema.create(Schema.Type.STRING)), null, null);
Schema schema = Schema.createRecord("my_record", "doc", "mytest", false);
```
Yes, I think this one is more correct (or less confusing). Otherwise, as it
was before, it creates nested maps (map in map). Not a big deal since finally
it still tests maps comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
