zcsizmadia commented on code in PR #2215:
URL: https://github.com/apache/avro/pull/2215#discussion_r1228496176
##########
lang/csharp/src/apache/main/CodeGen/CodeGen.cs:
##########
@@ -1136,6 +1136,48 @@
}
}
+ /// <summary>
+ /// Gets names and generated code of the schema(s) types
+ /// </summary>
+ /// <returns></returns>
+ public virtual IDictionary<string, string> GetTypes()
+ {
+ var cscp = new CSharpCodeProvider();
Review Comment:
I have no issue if you add "using" tin this PR where those other places are.
new CSharpCodeProvider is used without using. (if not too many). If too many
lets make another PR
Not having "using" IMO is considered a resource leak bug, so breaking the
pattern in such case is poreferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
