[GitHub] [avro] zcsizmadia commented on a diff in pull request #2215: AVRO-3756: [csharp] Add a method to return types instead of writing them to disk

Tue, 13 Jun 2023 12:20:07 -0700 


zcsizmadia commented on code in PR #2215:
URL: https://github.com/apache/avro/pull/2215#discussion_r1228593759


##########
lang/csharp/src/apache/main/CodeGen/CodeGen.cs:
##########
@@ -1136,6 +1136,48 @@
             }
         }
 
+        /// <summary>
+        /// Gets names and generated code of the schema(s) types
+        /// </summary>
+        /// <returns></returns>
+        public virtual IDictionary<string, string> GetTypes()
+        {
+            var cscp = new CSharpCodeProvider();

Review Comment:
   That using format is only C# 8+. You need to use using with brackets. Which 
sepcifies the scope explicitly.
   
![image](https://github.com/apache/avro/assets/8504099/fc30a6c4-fcfd-4881-b7e0-6e5fad6b2784)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to