zcsizmadia commented on code in PR #2439:
URL: https://github.com/apache/avro/pull/2439#discussion_r1293496616
##########
lang/csharp/src/apache/main/IO/BinaryDecoder.cs:
##########
@@ -296,5 +296,8 @@ private void Skip(long p)
{
stream.Seek(p, SeekOrigin.Current);
}
+
+ /// <inheritdoc />
+ public void Dispose() => stream?.Dispose();
Review Comment:
If the stream should be disposed when The BinaryDecoder is disposed, a new
constructor with `bool ownStream` can be added, which marks the stream for
disposal in the Decoder's Dispose. Similiarly what
https://github.com/apache/avro/blob/master/lang/csharp/src/apache/main/File/DataFileReader.cs#L125-L137.
Of course that feature is not really in the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
