zcsizmadia commented on code in PR #2439:
URL: https://github.com/apache/avro/pull/2439#discussion_r1295858752
##########
lang/csharp/src/apache/main/IO/BinaryDecoder.cs:
##########
@@ -298,6 +309,10 @@ private void Skip(long p)
}
/// <inheritdoc />
- public void Dispose() => stream?.Dispose();
+ public void Dispose()
+ {
+ if(!ownStream)
Review Comment:
Since the ownStream = false in the default constructor, the stream would be
disposed using the default constructor, which woulr make it a breaking change.
##########
lang/csharp/src/apache/main/IO/BinaryDecoder.cs:
##########
@@ -298,6 +309,10 @@ private void Skip(long p)
}
/// <inheritdoc />
- public void Dispose() => stream?.Dispose();
+ public void Dispose()
+ {
+ if(!ownStream)
Review Comment:
Since the ownStream = false in the default constructor, the stream would be
disposed using the default constructor, which would make it a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
