RikHeijdens commented on code in PR #2441:
URL: https://github.com/apache/avro/pull/2441#discussion_r1294317781
##########
lang/rust/avro/src/types.rs:
##########
@@ -377,6 +377,10 @@ impl Value {
}
}
+ /// Validates the value against the provided schema.
+ ///
+ /// Arguments:
+ /// * `schema_resolution` - whether schema resolution rules should be
applied when validating the `value`.
Review Comment:
Please remove the `Arguments` section from the doc comment or update the
description.
##########
lang/rust/avro/src/schema.rs:
##########
@@ -837,9 +837,11 @@ impl UnionSchema {
// extend known schemas with just resolved names
collected_names.extend(resolved_names);
let namespace = &schema.namespace().or_else(||
enclosing_namespace.clone());
+
value
- .validate_internal(schema, &collected_names, namespace)
- .is_none()
+ .clone()
Review Comment:
In contrast to my previously proposed solution this may cause the entire
`value` to be copied, just for the purpose of validation. That seems rather
expensive - but logically this would work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
