RikHeijdens commented on code in PR #2441:
URL: https://github.com/apache/avro/pull/2441#discussion_r1294462122
##########
lang/rust/avro/src/schema.rs:
##########
@@ -837,9 +837,11 @@ impl UnionSchema {
// extend known schemas with just resolved names
collected_names.extend(resolved_names);
let namespace = &schema.namespace().or_else(||
enclosing_namespace.clone());
+
value
- .validate_internal(schema, &collected_names, namespace)
- .is_none()
+ .clone()
Review Comment:
Yep - I understand the rationale. I had contemplated this exact solution and
went with the other one because it avoided an allocation :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
