opwvhk commented on code in PR #2282:
URL: https://github.com/apache/avro/pull/2282#discussion_r1325623771
##########
lang/java/avro/src/main/java/org/apache/avro/Conversions.java:
##########
@@ -146,6 +152,65 @@ private static BigDecimal validate(final
LogicalTypes.Decimal decimal, BigDecima
}
}
+ public static class BigDecimalConversion extends Conversion<BigDecimal> {
+
+ @Override
+ public Class<BigDecimal> getConvertedType() {
+ return BigDecimal.class;
+ }
+
+ @Override
+ public String getLogicalTypeName() {
+ return "bigdecimal";
Review Comment:
This name does not equals the one in the documentation and the tests. Can we
please adjust so they're the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
