RyanSkraba commented on code in PR #2537:
URL: https://github.com/apache/avro/pull/2537#discussion_r1343671860
##########
lang/rust/avro/benches/serde.rs:
##########
@@ -296,7 +296,7 @@ fn bench_big_schema_read_100_000_record(c: &mut Criterion) {
// This benchmark reads from the `benches/quickstop-null.avro` file, which was
pulled from
// the `goavro` project benchmarks:
-// https://github.com/linkedin/goavro/blob/master/fixtures/quickstop-null.avro
+// https://github.com/linkedin/goavro/blob/main/fixtures/quickstop-null.avro
Review Comment:
This doesn't look right!
##########
lang/php/README.md:
##########
@@ -28,7 +28,7 @@ your project's `composer.json` configuration file, and run
`composer install`:
```json
{
"require-dev": {
- "apache/avro": "dev-master"
+ "apache/avro": "dev-main"
Review Comment:
Looks like this is right:
https://getcomposer.org/doc/articles/aliases.md#why-aliases-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
