Fokko commented on code in PR #2554: URL: https://github.com/apache/avro/pull/2554#discussion_r1362464289
########## doc/content/en/docs/++version++/Specification/_index.md: ########## @@ -862,6 +862,11 @@ The `timestamp-micros` logical type represents an instant on the global timeline A `timestamp-micros` logical type annotates an Avro `long`, where the long stores the number of microseconds from the unix epoch, 1 January 1970 00:00:00.000000 UTC. +### Timestamp (nanosecond precision) +The `timestamp-nanos` logical type represents an instant on the global timeline, independent of a particular time zone or calendar, with a precision of one nanosecond. Please note that time zone information gets lost in this process. Upon reading a value back, we can only reconstruct the instant, but not the original representation. In practice, such timestamps are typically displayed to users in their local time zones, therefore they may be displayed differently depending on the execution environment. Review Comment: Thanks everyone for the great input here. I think we all agree that this needs some reworking. > Actually, I do not agree with the statement that "time zone information gets lost in this process": the paragraph below explicitly states the time zone in use. The timezone is always UTC. But the local timezone that the writer lives in, is lost. I would suggest removing this sentence since it is confusing. Any objections? > The timestamp logical types should have examples to clarify the semantics. No need to repeat those examples for each of -millis, -micros, and -nanos though. I agree there, and I also like the examples. I've restructured the documentation to remove the duplicate sections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
