martin-g commented on code in PR #2699:
URL: https://github.com/apache/avro/pull/2699#discussion_r1469292100
##########
.github/workflows/codeql-java-analysis.yml:
##########
@@ -70,17 +70,34 @@ jobs:
# queries: ./path/to/local/query, your-org/your-repo/queries@main
queries: +security-and-quality
+ - name: 'Setup Temurin JDK 8, 11, 17 & 21'
+ uses: actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93 #
v4.0.0
+ with:
+ distribution: 'temurin'
+ java-version: |
+ 8
Review Comment:
There was a
[discussion](https://lists.apache.org/thread/bd39zhk655pgzfctq763vp3z4xrjpx58)
recently at dev@ about dropping the support for Java 8.
##########
.github/workflows/codeql-java-analysis.yml:
##########
@@ -70,17 +70,34 @@ jobs:
# queries: ./path/to/local/query, your-org/your-repo/queries@main
queries: +security-and-quality
+ - name: 'Setup Temurin JDK 8, 11, 17 & 21'
+ uses: actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93 #
v4.0.0
+ with:
+ distribution: 'temurin'
+ java-version: |
+ 8
+ 11
+ 17
+ 21
Review Comment:
Do we need several JDKs for CodeQL analysis ?
CodeQL is ignored most of the time anyway
Update: OK, I think I understand it - we need them for toolchains.xml
##########
.github/workflows/test-lang-java.yml:
##########
@@ -90,28 +93,37 @@ jobs:
restore-keys: |
${{ runner.os }}-maven-
- - name: Setup Java
- uses: actions/setup-java@v4
+ - name: 'Setup Temurin JDK 8, 11, 17 & 21'
+ uses: actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93 #
v4.0.0
with:
distribution: 'temurin'
- java-version: ${{ matrix.java }}
+ java-version: |
+ 8
+ 11
+ 17
+ 21
+
+ - name: 'Setup Maven 3.9.6'
+ uses: stCarolas/setup-maven@07fbbe97d97ef44336b7382563d66743297e442f #
v4.5
+ with:
+ maven-version: 3.9.6
- - name: Setup Python for Generating Input Data
- uses: actions/setup-python@v5
+ - name: 'Setup Python for Generating Input Data'
+ uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c #
v5.0.0
- - name: Apt Install Compression Libs Required by Python
+ - name: 'Apt Install Compression Libs Required by Python'
Review Comment:
The quotes are not really needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
