opwvhk commented on code in PR #2699:
URL: https://github.com/apache/avro/pull/2699#discussion_r1471439371
##########
lang/java/avro/pom.xml:
##########
@@ -55,7 +55,42 @@
</includes>
</resource>
</resources>
+ <testResources>
+ <testResource>
+ <directory>src/test/resources</directory>
+ </testResource>
+ <testResource>
+ <directory>../../../share/</directory>
+ <includes>
+ <include>schemas/**</include>
+ <include>test/**</include>
+ </includes>
+ <targetPath>share/</targetPath>
+ </testResource>
+ </testResources>
+
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-toolchains-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>Build using JDK 21</id>
+ <phase>validate</phase>
+ <goals>
+ <goal>toolchain</goal>
+ </goals>
+ <configuration>
+ <toolchains>
+ <jdk>
+ <version>21</version>
+ </jdk>
+ </toolchains>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review Comment:
The toolchain plugin is also copied into the modules. Is that needed? Can't
it inherit from here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
