Fokko commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1480394485
##########
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##########
@@ -1546,26 +1461,13 @@ public Schema parse(File file) throws IOException {
return parse(FACTORY.createParser(file), false);
}
- public List<Schema> parse(Iterable<File> sources) throws IOException {
Review Comment:
I'm very concerned about breaking public API's
##########
lang/java/avro/src/main/java/org/apache/avro/util/SchemaResolver.java:
##########
@@ -111,67 +105,6 @@ public static boolean isFullyResolvedSchema(final Schema
schema) {
}
}
- /**
- * Clone the provided schema while resolving all unreferenced schemas.
- *
- * @param parseContext the parse context with known names
- * @param schema the schema to resolve
- * @return a copy of the schema with all schemas resolved
- */
- public static Schema resolve(final ParseContext parseContext, Schema schema)
{
Review Comment:
Can we just remove those methods? I think other libraries might be relying
on these. Should we first deprecate and then remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
