opwvhk commented on PR #2642: URL: https://github.com/apache/avro/pull/2642#issuecomment-1943282582
> I tried to review this, but don't know where to start. The schema parser is very fundamental and there are 150+ files to review. My biggest concern is about breaking public API's. We had this in the Avro 1.8 to 1.9 version because we had to remove codehaus Jackson from the public API, and it was very hard to get this downstream into other projects. These are valid concerns, so I'll address them each. Breaking API's: * Are not intended: all existing methods should be deprecated instead. * There's only one exception that I know of: `Parser.parse(Iterable<File>)` was added after the last release (#2375) PR size: * Largely unavoidable, given how much we use the parser * Starting point is separating the parser and its tests from the rest * The parser requires extra scrutiny, the rest is of the category "it works, so it's good enough if it's readable" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
