Gerrit0 commented on code in PR #2931:
URL: https://github.com/apache/avro/pull/2931#discussion_r1622602372


##########
lang/c++/test/CodecTests.cc:
##########
@@ -25,7 +25,7 @@
 #include "Specific.hh"
 #include "ValidSchema.hh"
 
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>

Review Comment:
   Recent versions of boost have effectively deprecated this header, we don't 
use placeholders, so no additional changes are required:
   
   ```
   In file included from /usr/include/boost/bind.hpp:30,
                    from 
/home/gerrit/Desktop/avro/lang/c++/test/CodecTests.cc:28:
   /usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of 
declaring the Bind placeholders (_1, _2, ...) in the global namespace is 
deprecated. Please use <boost/bind/bind.hpp> + using namespace 
boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the 
current behavior.’
      36 | BOOST_PRAGMA_MESSAGE(
         | ^~~~~~~~~~~~~~~~~~~~
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to