Gerrit0 commented on code in PR #2931:
URL: https://github.com/apache/avro/pull/2931#discussion_r1622612920
##########
lang/c++/test/CommonsSchemasTests.cc:
##########
@@ -45,8 +45,7 @@ void testCommonSchema(const std::filesystem::path &dir_path) {
DataFileWriter<GenericDatum> writer(outputDataFile.c_str(), schema);
while (reader.read(datum)) {
- avro::GenericRecord &rec = datum.value<avro::GenericRecord>();
- BOOST_CHECK(rec.fieldCount() >= 0);
Review Comment:
This check is useless as `fieldCount()` returns an unsigned value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
