martin-g commented on PR #514: URL: https://github.com/apache/avro-rs/pull/514#issuecomment-4121333379
> I also suggest removing all the added inline attributes. The compiler does inlining most of the time, and unless it has a measurable performance impact in benchmarks the attribute just adds visual noise (see also the description of [`clippy::missing_inline_in_public_items`](https://rust-lang.github.io/rust-clippy/master/?search=inline#missing_inline_in_public_items) which is a `restriction` lint for a reason) All `#[inline]`s have been added because Clippy suggested to add them and because they don't do any harm either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
