fabiocfabini commented on PR #3732:
URL: https://github.com/apache/avro/pull/3732#issuecomment-4562716793
> thank you suggesstion, i have see the first issue will be fix soon , the
function `avro_max_read` purpose to prevent wrong num mem alloc, may be bigger
than INT_MAX. str_len from code `read_long(reader, len)`
I've checked the new changes you applied to #3635 Even with the new changes
these tests still fail:
```
94% tests passed, 3 tests failed out of 50
Total Test time (real) = 18.84 sec
The following tests FAILED:
1 - quickstop (Failed)
38 - test_avro_1572 (Failed)
39 - memcheck_test_avro_1572 (Failed)
```
These are likely due o the addition of `avro_max_read` that is not
maintaining some sort of invariant of the code base. I don't think such
function should be added in this specific PR given as it seems to be outside
the scope of the problem we are trying to fix.
It also proves to be somewhat concerning that tests keep failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
