fabiocfabini commented on PR #3732: URL: https://github.com/apache/avro/pull/3732#issuecomment-4562801674
> the pr #3732 contains pr #3635, and remove function `avro_max_read`, add some unit test, it should stated that the idea for the changes came from #3635 I am not sure what you mean by the last point. I came about this problem by accident when using avro myself. I looked to see if an issue existed on the matter. Saw your issue but was unsatisfied with the solution approach so decided to add my own 2 cents :slightly_smiling_face:. To be clear, our implementations are different. Even the part you could argue is more similar, the `AVRO_READ_OR_FREE` macro, is not the same implementation. #3635 implementation accepts an extra parameter which is the desired memory length after resizing. Well, I would say that the desired size is 0, hence the name, `AVRO_READ_OR_FREE`. In your implementation you set this parameter to `*len +1`. Not sure why but maybe it is also causing some of the tests failing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
